Skip to content

Remove unused test headers #10394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Remove unused test headers #10394

wants to merge 1 commit into from

Conversation

gilles-peskine-arm
Copy link
Contributor

Move tests/include/alt-dummy/*_alt.h to TF-PSA-Crypto where they belong.

PR checklist

@gilles-peskine-arm gilles-peskine-arm added needs-ci Needs to pass CI tests priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Sep 9, 2025
@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Sep 9, 2025
Merged
4 tasks
@gilles-peskine-arm gilles-peskine-arm force-pushed the threading-1.0-alt-build-mbedtls branch from 8f85fe4 to 6f72834 Compare September 9, 2025 17:12
@gilles-peskine-arm gilles-peskine-arm added priority-medium Medium priority - this can be reviewed as time permits needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review needs-preceding-pr Requires another PR to be merged first and removed priority-high High priority - will be reviewed soon needs-ci Needs to pass CI tests labels Sep 12, 2025
@gilles-peskine-arm gilles-peskine-arm force-pushed the threading-1.0-alt-build-mbedtls branch from 6f72834 to 8359f77 Compare September 12, 2025 10:39
@gilles-peskine-arm gilles-peskine-arm removed the needs-preceding-pr Requires another PR to be merged first label Sep 12, 2025
@mpg
Copy link
Contributor

mpg commented Sep 15, 2025

This has a conflict but also a CI failure that looks real, considering all 3 CIs have the same single component failing.

@gilles-peskine-arm gilles-peskine-arm mentioned this pull request Sep 17, 2025
Open
4 tasks
@gilles-peskine-arm
Remove platform alt headers for testing
009c150 
All the platform configuration is in the crypto submodule, so the headers to
test it should be there.

Signed-off-by: Gilles Peskine <[email protected]>
@gilles-peskine-arm gilles-peskine-arm force-pushed the threading-1.0-alt-build-mbedtls branch from 8359f77 to 009c150 Compare September 17, 2025 19:11
mpg
mpg approved these changes Sep 19, 2025
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpg mpg mpg approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-medium Medium priority - this can be reviewed as time permits size-xs Estimated task size: extra small (a few hours at most)

Projects

Roadmap pull requests (new board)
Status: In Development

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gilles-peskine-arm @mpg